Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tests quieter #581

Merged
merged 1 commit into from Jan 26, 2022
Merged

Keep tests quieter #581

merged 1 commit into from Jan 26, 2022

Conversation

captn3m0
Copy link
Contributor

@captn3m0 captn3m0 commented Jan 18, 2022

  • Asserts for one intentional warning on empty tables
  • Fixes width to "None" to avoid another warning where an empty string
    results in a warning

Thought I'd start with a simpler PR before #560

This currently breaks on Python 2.7 (which will get dropped with #582 anyway)

Before:

python -m unittest discover
.............................................................................<table> is empty
'<table> </table>'
.......getSize: Not a float ''
................................................................................
----------------------------------------------------------------------
Ran 164 tests in 0.656s

OK

After:

python -m unittest discover
....................................................................................................................................................................
----------------------------------------------------------------------
Ran 164 tests in 0.655s

OK

- Asserts for one intentional warning on empty tables
- Fixes width to "None" to avoid another warning where an empty string
  results in a warning
@luisza luisza merged commit 9f53ca6 into xhtml2pdf:master Jan 26, 2022
@captn3m0 captn3m0 deleted the quiet-tests branch January 27, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants