New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to reportlab 4 #708
Conversation
@stefan6419846 do you think this will do? |
Apart from the fact that this will break reportlab 3 due to the requirements and enforce the (recommended, but not yet officially required) Cairo backend, it looks okay for me. To avoid this, we probably would have to utilize requirement extras groups, which I am not sure of how much additional maintenance effort this would introduce. |
- Remove version restriction - Document installation of C extensions
4a08525
to
d2facd9
Compare
Hmm yes, I agree that it's not ideal. But for now probably better than the previous restriction. At least people who rely on old versions of reportlab can just pin xhtml2pdf to an older version as well... |
I am still debugging it, so I am sharing in case someone else had the same issue with the new version, I have reportlab==4.0.7 and xhtml2pdf==0.2.12. I am getting the exception:
I will do some digging before stating it is an issue/bug. |
Yeah, it is a bug caused by a refactoring when the ruff linter was added: I will create a separate issue for that. Edit |
Short description
Update to reportlab 4
Proposed changes
Resolved issues
Fixes: #699