Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo install fails because of inconsistent crossbeam versions #1240

Closed
mcobzarenco opened this issue Nov 16, 2019 · 3 comments · Fixed by #1243
Closed

Cargo install fails because of inconsistent crossbeam versions #1240

mcobzarenco opened this issue Nov 16, 2019 · 3 comments · Fixed by #1243

Comments

@mcobzarenco
Copy link

mcobzarenco commented Nov 16, 2019

Details

Running cargo run install -f . on master fails with the message below (I think this was caused by upgrading notify in this commit, I can build it successfully 1 commit before).

error[E0308]: mismatched types
   --> core-lib/src/watcher.rs:101:29
    |
101 |         let inner = watcher(tx_event, Duration::from_millis(100)).expect("watcher should spawn");
    |                             ^^^^^^^^ expected struct `crossbeam_channel::channel::Sender`, found a different struct `crossbeam_channel::channel::Sender`
    |
    = note: expected type `crossbeam_channel::channel::Sender<std::result::Result<notify::Event, notify::Error>>`
               found type `crossbeam_channel::channel::Sender<_>`

Environment

Ubuntu 18.04
rustc 1.38.0 (625451e37 2019-09-23)
@Cogitri
Copy link
Member

Cogitri commented Nov 16, 2019

Can you run cargo update and try again?

@mcobzarenco
Copy link
Author

mcobzarenco commented Nov 16, 2019

I have tried cargo update to no avail; it updates these crossbeam dependencies:

...
    Updating crossbeam v0.7.2 -> v0.7.3
      Adding crossbeam-channel v0.4.0
    Updating crossbeam-deque v0.7.1 -> v0.7.2
    Updating crossbeam-epoch v0.7.2 -> v0.8.0
    Updating crossbeam-queue v0.1.2 -> v0.2.0
      Adding crossbeam-utils v0.7.0
...

I'm happy to try to submit a PR to fix it if you could point me in the right direction, but it's not clear to me which 2 crates have conflicting crossbeam dependencies -- the two places where crossbeam is used:

rust/rpc/Cargo.toml
15:crossbeam = "0.7"

rust/core-lib/Cargo.toml
20:crossbeam = "0.7"

@Cogitri
Copy link
Member

Cogitri commented Nov 17, 2019

rpc expects a different version than core-lib apparently. Dunno why that happens though since both should use the same cargo.lock 🤔

A PR would be nice.

@mcobzarenco mcobzarenco changed the title Cargo install fails because of incosistent crossbeam versions Cargo install fails because of inconsistent crossbeam versions Nov 25, 2019
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Nov 30, 2019
notify-0.5 only supports crossbeam-channel 0.3 as of now.

fixes xi-editor#1240 xi-editor#1242
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Dec 1, 2019
notify-0.5 only supports crossbeam-channel 0.3 as of now.

fixes xi-editor#1240 xi-editor#1242
Cogitri added a commit to Cogitri/xi-editor that referenced this issue Dec 1, 2019
notify-0.5 only supports crossbeam-channel 0.3 as of now.

fixes xi-editor#1240 xi-editor#1242
Cogitri added a commit that referenced this issue Dec 1, 2019
notify-0.5 only supports crossbeam-channel 0.3 as of now.

fixes #1240 #1242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants