Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at_or_next and at_or_prev to Cursor #1019

Merged
merged 1 commit into from Nov 29, 2018

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Nov 29, 2018

Another little fixup that can stand alone.

Review Checklist

  • I have responded to reviews and made changes where appropriate.
  • I have tested the code with cargo test --all / ./rust/run_all_checks.
  • I have updated comments / documentation related to the changes I made.
  • I have rebased my PR branch onto xi-editor/master.

Copy link
Member

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean functionality that can simplify client code, thanks!

@@ -948,4 +968,19 @@ mod test {
}
}

#[test]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test for at_or_prev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic functionality for both is included in this test case, didn't feel this was complicated enough to warrant serious energy.

@cmyr cmyr merged commit a12cd62 into xi-editor:master Nov 29, 2018
@cmyr cmyr deleted the quick/cursor-at-or-next branch November 29, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants