Identifiers are now real types #292
Conversation
rust/core-lib/src/plugins/manager.rs
Outdated
| .editor_for_view(&view_id2) { | ||
| ed.plugin_started(&view_id2, &key.1); | ||
| running = true; | ||
| } |
There was a problem hiding this comment.
This close paren is mis-indented.
But more importantly, why did you change this from how it was before to add the running variable? Since running only becomes true in the if block, why not remove the running variable and put inner.running.insert(key, plugin_ref) inside the if block.
There was a problem hiding this comment.
hmm, I was doing it this way because inner.running.insert is a mutable borrow, and we have an immutable borrow out when we take editor_for_view. It's possible I'm missing something. Just moving it into the if block doesn't compile.
My editor wants to align that closing brace with the second line of the opening expression. I don't really have an opinion here, will change, but it might get reverted next time I fix whitespace 😐.
There was a problem hiding this comment.
Darn borrow checker. Having to do dumb things like that for no good reason when using mutable borrows is one of my least favourite things about Rust.
…shortcuts Added selectors for xi-editor#171
This patch makes better use of the type system to distinguish between
BufferIdentifierandViewIdentifier.There were a few spots in the plugin code where this was poorly distinguished, and this change makes me a bit more considered about those places. It also will make it easier to use some value type as an identifier in the future.