Add support for duplicating lines #792
Conversation
| fn duplicate_line(&mut self, view: &View, config: &BufferItems) { | ||
| let mut builder = delta::Builder::new(self.text.len()); | ||
| // get affected lines | ||
| let mut lines = BTreeSet::new(); |
There was a problem hiding this comment.
This part is almost the same as in modify_indent. Perhaps there is a way to reuse the code...
There was a problem hiding this comment.
that could make sense at some point, feels like this is okay for now though.
| fn duplicate_line(&mut self, view: &View, config: &BufferItems) { | ||
| let mut builder = delta::Builder::new(self.text.len()); | ||
| // get affected lines | ||
| let mut lines = BTreeSet::new(); |
There was a problem hiding this comment.
that could make sense at some point, feels like this is okay for now though.
|
I added it under "Other movement and deletion commands". Not sure if that is the right section though. |
|
I noticed Travis has been building this branch for a while. Maybe something got stuck? |
|
hmm, good point. I checked and it said it passed, just this graphic hasn't updated? |
|
After duplicating multiple lines the selection is somewhat unexpected:
This makes it hard to run |
|
hmm good point, I think I'd call that a bug. @scholtzan? |
|
Oh, I will look into it. |
Duplicates lines that are selected