Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find UI magnifier icon not shown #120

Closed
rkusa opened this issue Jan 26, 2018 · 2 comments
Closed

Find UI magnifier icon not shown #120

rkusa opened this issue Jan 26, 2018 · 2 comments
Labels

Comments

@rkusa
Copy link
Contributor

rkusa commented Jan 26, 2018

The magnifier icon in the Find bar is not shown anymore.

screen shot 2018-01-26 at 14 50 30

I was able to track this issue back to the changes in Main.stroyboard in dc4840e.

Unfortunately, I have no idea how to fix this. Maybe the NSSearchField itself is buggy?

@rkusa
Copy link
Contributor Author

rkusa commented Jan 26, 2018

I am more or less just guessing, but could it be due to the EditView being a layer-hosting view now? I found the following in the docs about layer-hosting views:

Similarly, do not add subviews to a layer-hosting view.

But we are adding the FindViewController's view as a subview to EditView.

@cmyr
Copy link
Member

cmyr commented Jan 26, 2018

I think you're right. There should be a fairly trivial work-around, which would be to have the find view be a sibling of EditView, probably a child of EditContainerView?

@rkusa rkusa mentioned this issue Mar 19, 2018
@scholtzan scholtzan mentioned this issue Apr 26, 2018
8 tasks
cmyr added a commit to cmyr/xi-mac that referenced this issue May 28, 2018
cmyr added a commit to cmyr/xi-mac that referenced this issue May 28, 2018
@cmyr cmyr closed this as completed in c605c48 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants