Upgrade to Swift 5! #464
Merged
Upgrade to Swift 5! #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
May 5, 2019
| @@ -543,6 +543,9 @@ extension EditViewController { | |||
|
|
|||
| case .hideReplaceInterface: | |||
| Swift.print("hideReplaceInterface not implemented") | |||
|
|
|||
| @unknown default: | |||
There was a problem hiding this comment.
what's this syntax? Can you link me a reference?
There was a problem hiding this comment.
I just learned about it while upgrading also. It allows us to have an exhaustive enum with a default case to protect against future additions to the enum. If we don't put the @unknown on the default, the compiler will complain that we've covered all the cases already.
https://github.com/apple/swift-evolution/blob/master/proposals/0192-non-exhaustive-enums.md#unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the codebase to Swift 5. It will require compiling with Xcode 10.2.
The most significant change is the raw byte handling in
RPCSending.swiftso please review that closely... I think I've gotten it right with hopefully similar performance!Related Issues
Related to #463
Example: Closes #461
Checklist
Review Checklist