Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cann't get syntax highlighting to work #110

Open
o01eg opened this issue Jul 9, 2019 · 10 comments
Open

Cann't get syntax highlighting to work #110

o01eg opened this issue Jul 9, 2019 · 10 comments

Comments

@o01eg
Copy link

o01eg commented Jul 9, 2019

I have installed xi-core and xi-term in /usr/bin, and syntect in /usr/share/xi/plugins/.

When I open file in xi-term I didn't get syntax highlight.

xi-term.log

xi-term.rpc.log

xi-core.log

@o01eg
Copy link
Author

o01eg commented Jul 9, 2019

Looks like it should set client_extras_dir parameter for client_started message.

@o01eg
Copy link
Author

o01eg commented Jul 9, 2019

What if use option_env! to allow set this value?

@msirringhaus
Copy link

I have it under $HOME/.config/xi/plugins/, there it works.

@o01eg
Copy link
Author

o01eg commented Jul 12, 2019

It is not useful for system-wide installation or noexec on home folder.

@msirringhaus
Copy link

Have you tried setting the approriate XDG environment variables?
I think xi-term and xi-core are using those.

@o01eg
Copy link
Author

o01eg commented Jul 12, 2019

I suppose those variables don't intended to point to read-only folders.

@msirringhaus
Copy link

Ok, think you are right about client_extras_dir, which needs to be set.
Question is, is there a sensible mapping to XDG? XDG_DATA_DIRS are per default under /usr/ (which usually is read only for normal users) and extra_dirs is supposed to be

An optional client-provided path for bundled resources, such
as plugins and themes.

So this might be a good fit?

@o01eg
Copy link
Author

o01eg commented Jul 12, 2019

Looks reasonable, but XDG_DATA_DIRS is a multiple dirs. Could xi-core changed to accept multiple dirs in client_extras_dir or so parameter?

@msirringhaus
Copy link

Hm, either that or xi-term goes over $XDG_DATA_HOME:$XDG_DATA_DIRS one by one and checks if a xi/-subdirectory exists. If so, it takes it and sends it along. This would of course always take the first hit and ignore the others.

@Cogitri
Copy link

Cogitri commented Jul 12, 2019

/usr/share/xi/plugins/

That doesn't seem like the right location though, share usually is meant for arch independent stuff (icons, themes etc.), while binaries (like the plugins) should be in lib or libexec. Anyway,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants