-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why chose client-side code highlighting over builtin server-side func? #28
Comments
Thanks for your feedback! I haven't tested the |
Yeah, I guess it’s not complicated to add Chroma support.
…Sent from my iPhone
On Apr 8, 2018, at 7:52 PM, Chen Xianmin ***@***.***> wrote:
Thanks for your feedback!
This project Initial version is olOwOlo/hugo-theme-even. Hugo-theme-even use highlight.js library, and for me, the style of the show is not bad. So I did not modify it.
I haven't tested the =Chroma= yet. Maybe we can try it? 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
IMHO server-side highlighting pros:
while client-side highlighting can:
|
Yes, less 3rd-party dependencies is better. The |
@xianmin You've hardcoded highlight invocations in |
If |
I'd like to have this migration done. Tell me if anybody is working on this. If not, I can do it. |
@Zebradil I'm currently busy at my work, please give it a go if you have time, thanks. |
@jostyee, I'll go for it this week then. |
@xianmin, what is the highlight style used? It looks like solarized-light, but it's not the same. Solarized-light from https://github.com/john2x/solarized-pygment/: |
@Zebradil This highlight style is good! If anyone wants change the style, I think they could use custom css. |
@Zebradil great work, thanks. |
Another way to change style is to use hugo's
With this approach it's possible to tune highlight style manually. |
Hugo does support code highlighting since version 0.28 adopted from Chroma, by which we don't need the highlight javascript library to do the job, I wonder why @xianmin chose not to use it?
Some other themes for comparison:
The text was updated successfully, but these errors were encountered: