Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Migration from highlight.js to Chroma #43

Merged
merged 3 commits into from
Apr 22, 2018
Merged

♻️ Migration from highlight.js to Chroma #43

merged 3 commits into from
Apr 22, 2018

Conversation

Zebradil
Copy link
Collaborator

Fix for #28.

@xianmin
Copy link
Owner

xianmin commented Apr 22, 2018

You did a great job!
I did not expect that there is not much difference from the original highlight.

Only a small problem:

deepinscreenshot_select-area_20180422085309

The <code> tag padding in paragraph is not suitable. It's ok. I will fix this in the next commit.

@xianmin xianmin merged commit c80a3ed into xianmin:master Apr 22, 2018
xianmin added a commit that referenced this pull request Apr 22, 2018
@xianmin
Merge pull request #43 from Zebradil/master
e683155 
♻️ Migration from highlight.js to Chroma
@xianmin xianmin mentioned this pull request Apr 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zebradil @xianmin