-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows dll .edata Name RVA #127
Comments
@zchothia , any suggestion? Xianyi |
Thanks for the pointing this out. I agree with your assessment and would be inclined to take either option 2 or 3. Whilst option 4 is technically possible, I would dissuade from its use due to the added complexity it would bring. Personally I think option 2 is most appropriate, since |
Yeah, taking option 2 sounds good to me. |
When building with MinGW on windows openblas creates both
openblas-r0.2.2.dll
and also symlinks (which is really a hardlink on windows) toopenblas.dll
. However, while this maybe a valid thing to do on other platforms, the PE/COFF format contains something called the "Name RVA" in the.edata
section. However, this causes the problem that libraries and executables linking directly toopenblas.dll
cannot find the dll afterwards as they expect it to calledopenblas-r0.2.2.dll
in accordance with the "Name RVA". I am unsure about the correct solution to this, but I see the following possibilities:openblas.dll
and useopenblas-r0.2.2.dll
openblas-r0.2.2.dll
and useopenblas.dll
openblas.dll
to have the correct "Name RVA"I would prefer to keep
openblas.dll
so I'm really fine with 2-4, but would tend more towards 3-4, though I am unsure as to the feasibility of 4. Let me know what you think the the best solution is and I can probably implement it (or you could implement it yourself).The text was updated successfully, but these errors were encountered: