Skip to content

Commit

Permalink
Fix number-based mouse bindings
Browse files Browse the repository at this point in the history
The toml migration introduced a regression which stopped numbered key
binding's from working. This patch implements the required number type
to make things work again.

Fixes alacritty#7527.
  • Loading branch information
lfrancke committed Jan 2, 2024
1 parent 659550e commit 8f57367
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Blurry window when using `window.dimensions` on some Wayland compositors
- IME input lagging behind on X11
- xdotool modifiers input not working correctly on X11
- Parsing numbers fails for mouse bindings

## 0.13.0

Expand Down
10 changes: 10 additions & 0 deletions alacritty/src/config/bindings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,16 @@ impl<'a> Deserialize<'a> for MouseButtonWrapper {
f.write_str("Left, Right, Middle, Back, Forward, or a number from 0 to 65536")
}

fn visit_i64<E>(self, value: i64) -> Result<MouseButtonWrapper, E>
where
E: de::Error,
{
match value {
0..=65536 => Ok(MouseButtonWrapper(MouseButton::Other(value as u16))),
_ => Err(E::invalid_value(Unexpected::Signed(value), &self)),
}
}

fn visit_u64<E>(self, value: u64) -> Result<MouseButtonWrapper, E>
where
E: de::Error,
Expand Down

0 comments on commit 8f57367

Please sign in to comment.