Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails navigation. #189

Closed
wants to merge 7 commits into from
Closed

Thumbnails navigation. #189

wants to merge 7 commits into from

Conversation

m00n-als
Copy link

@m00n-als m00n-als commented May 3, 2017

No description provided.

@xiaolin
Copy link
Owner

xiaolin commented May 3, 2017

Thanks for the PR, will take a look soon!

@xiaolin xiaolin self-assigned this May 3, 2017
@xiaolin xiaolin self-requested a review May 3, 2017 13:34
@ridmitri
Copy link

Hey @xiaolin, how about merging this feature? Looking forward to involve this gallery into my project too, would be cool to use these thumbnails there

@xiaolin
Copy link
Owner

xiaolin commented May 18, 2017

I'll take a look this weekend, I notice @m00n-als adding changes, so thought Id give him some more time 👍

@xiaolin
Copy link
Owner

xiaolin commented May 22, 2017

@m00n-als Thanks for opening the PR, and making the code easy to read and follow. Right now the thumbnail swiping doesn't feel natural. I'm aiming to make the gallery similar to how iOS photos handle their thumbnail swiping. If you wanna take a stab at that it would be great, if not I'll try to implement it soon.

@m00n-als
Copy link
Author

@xiaolin I'll try to make thumbnail swiping more natural. Maybe this weekend. If there are any difficulties, I'll write.

@mjvalade
Copy link

Hi @xiaolin any progress on this? Adding some nav arrows and swiping for the thumbnails would be a great addition for our users. Thanks!

@xiaolin
Copy link
Owner

xiaolin commented Sep 14, 2017

@mjvalade I have not had time to finish up this feature. I was working on a branch with this feature, but it got a bit complicated. I'll take another look when I get some time.

@xiaolin xiaolin mentioned this pull request Nov 6, 2017
@xiaolin
Copy link
Owner

xiaolin commented Dec 16, 2017

Cleaning up some PRs, and notice this has been hanging around. Closing this as its not the ideal UX for the gallery. Feel free to open a new pr with updates when available.

@xiaolin xiaolin closed this Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants