Skip to content

Commit

Permalink
[PATCH] kexec-ppc: fix for ksysfs crash_notes
Browse files Browse the repository at this point in the history
The following patch prevents the crash dump helper code found within kexec
from breaking ppc which still lacks crash dump functionality.

ksysfs crash_notes attribute handling was left under CONFIG_KEXEC for
simplicity although it is not strictly kexec related.

We provide here a dummy definition for crash_notes on ppc.

Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
herraa1 authored and Linus Torvalds committed Jul 12, 2005
1 parent 41e2e8b commit bc75a24
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
6 changes: 6 additions & 0 deletions arch/ppc/kernel/machine_kexec.c
Expand Up @@ -28,6 +28,12 @@ typedef NORET_TYPE void (*relocate_new_kernel_t)(
const extern unsigned char relocate_new_kernel[];
const extern unsigned int relocate_new_kernel_size;

/*
* Provide a dummy crash_notes definition while crash dump arrives to ppc.
* This prevents breakage of crash_notes attribute in kernel/ksysfs.c.
*/
void *crash_notes = NULL;

void machine_shutdown(void)
{
if (ppc_md.machine_shutdown)
Expand Down
2 changes: 2 additions & 0 deletions include/asm-ppc/kexec.h
Expand Up @@ -27,6 +27,8 @@

#ifndef __ASSEMBLY__

extern void *crash_notes;

struct kimage;

extern void machine_kexec_simple(struct kimage *image);
Expand Down

0 comments on commit bc75a24

Please sign in to comment.