Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of complex breaks code that include complex.h #115

Closed
lysnikolaou opened this issue Aug 14, 2023 · 1 comment · Fixed by #116
Closed

Usage of complex breaks code that include complex.h #115

lysnikolaou opened this issue Aug 14, 2023 · 1 comment · Fixed by #116

Comments

@lysnikolaou
Copy link
Contributor

Because of the typedef here and all its usages, code that uses SuperLU and also includes the complex.h header (that makes complex a reserved keyword) fails to compile.

Example issue: scipy/scipy#19036

If you agree to change this, I can start working on a PR. My understanding is that we'd have to do the following:

  • Patch any usages of complex in CBLAS and f2c-generated code. We've been doing this on numpy, so it shouldn't be too hard.
  • Change the typedef linked to above and all of its usages to something like singlecomplex.

What do you think?
lysnikolaou added a commit to lysnikolaou/superlu that referenced this issue Aug 17, 2023
@lysnikolaou
Rename complex occurences to singlecomplex
2bbc0f3 
- This is to avoid conflicts in packages that use both the `complex.h`
  header and SuperLU.

Closes xiaoyeli#115.
@lysnikolaou lysnikolaou mentioned this issue Aug 17, 2023
Merged
@lysnikolaou
Copy link
Contributor Author

Slight ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename complex occurences to singlecomplex lysnikolaou/superlu
1 participant
@lysnikolaou