testing/matgen: reduce use of f2c.h #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruenich
force-pushed
the
feature/testing-reduce-f2c
branch
from
2a7cf6d
to
74c563a
Compare
Replace f2c' use of int with TRUE_ and FALSE_
dmin is never used dmax is replaced by fmax from math.h
Does not overwrite setting by user, if variables are set.
gruenich
force-pushed
the
feature/testing-reduce-f2c
branch
from
74c563a
to
21140dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All contents of TESTING/MATGEN does not feel to be C code, it is rather awkward Fortran code. I replaced some of the typedefs inspired by Fortran. My goal is to get rid of f2c.h altogether for TESTING/MATGEN. But I piled up to many changes, once they get merged I will carry on.
Further, when using CMake, I forced the use of C99 mode , if nothing is defined by the user.