-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: add translation windows when invoked from console #1173
Conversation
edb7655
to
bc99329
Compare
From the help message, it is almost impossible to deduce that the thing followed by Why not add 2 new flags
If no flags exist, then it will be decided by the 馃挕 on toolbar. There should be something that can translate words directly |
src/ui/mainwindow.cc
Outdated
if ( message.left( 15 ) == "translateWord: " ) { | ||
if ( scanPopup ) | ||
if ( ( consoleWindowOnce == "popup" ) && scanPopup ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The && is questionable.
Right now, without any flags, the 馃挕 decided where the word will go when just using goldendict <word>
.
After this, turning on the 馃挕 will always go to main window with goldendict <word>
.
I think the -w
should be an "override" or "enforce" flag that says "This must be done" instead of requiring it to send to scanpopup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ( scanPopup )
will always be true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
-w
should be an "override" or "enforce" flag that says "This must be done" instead of requiring it to send to scanpopup.
agree
seems this logic has been lost. |
Right 馃槄. Should have replaced most |
8f794f9
to
066ef47
Compare
p is already been used |
48e3a86
to
ac6b3a7
Compare
then how about
is much shorter than
|
ac6b3a7
to
0f7d7fc
Compare
cd46890
to
1dba32d
Compare
SonarCloud Quality Gate failed.聽 聽
|
done |
show the translation in popup
show the translation in main windows
Without the above argument, the logic will follow the logic:
if 馃挕 checked, use popup ,or use mainwindow.