Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget: Stocks and Currencies invalid duration when items per page is used #2462

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dasgarner
Copy link
Member

Widget uses maxItemsPerPage instead of itemsPerPage. Also improve error responses from AlphaVantageConnector.

fixes xibosignage/xibo#3368

…Page. Also improve error responses from AlphaVantageConnector.

 fixes xibosignage/xibo#3368
@dasgarner dasgarner self-assigned this Mar 28, 2024
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ifarzana
Copy link
Contributor

ifarzana commented Apr 3, 2024

TEST: /Layout END

Copy link

github-actions bot commented Apr 3, 2024

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/8542320912

@dasgarner dasgarner merged commit a467a2a into develop Apr 4, 2024
3 checks passed
@dasgarner dasgarner deleted the bugfix/westphal_stocks_duration_per_page branch April 4, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants