Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Campaign - displayOrder not set correctly #1468

Closed
PeterMis opened this issue Apr 3, 2018 · 0 comments
Closed

Campaign - displayOrder not set correctly #1468

PeterMis opened this issue Apr 3, 2018 · 0 comments
Assignees
@dasgarner
Labels
bug
Milestone
1.8.10

Comments

@PeterMis
Copy link
Member

PeterMis commented Apr 3, 2018

When assigning layouts and changing their order in the campaign the displayOrder isn't always correctly set on all layouts.

It is especially apparent when adding/removing layouts from assignments and re-ordering the ones that are left - if we change only displayOrder then that seems to work correctly.

For example, add new layout, move it to the first position and Save
Open the form again and see the displayOrder.
@PeterMis PeterMis added the bug label Apr 3, 2018
@PeterMis PeterMis added this to the 1.8.9 milestone Apr 3, 2018
@dasgarner dasgarner modified the milestones: 1.8.9, 1.8.10 Apr 16, 2018
@dasgarner dasgarner self-assigned this Jun 15, 2018
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Jun 18, 2018
@dasgarner
Improved JavaScript used to track Layout assignments on the Campaign …
568e2a7 
…assign form - also updated sortable to freeze locked Layouts and prevent un-assignment.

xibosignage/xibo#1468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
bug
Projects
None yet
Milestone
1.8.10
Development

No branches or pull requests
2 participants
@dasgarner @PeterMis