Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Mcrypt #1615

Closed
alexharrington opened this issue Aug 21, 2018 · 3 comments
Closed

Investigate Mcrypt #1615

alexharrington opened this issue Aug 21, 2018 · 3 comments
Assignees
Labels
enhancement An improvement to an existing feature
Milestone

Comments

@alexharrington
Copy link
Member

PHP 7.1 deprecates and PHP 7.2 removes the mcrypt module, as it's no longer maintained.

Investigate whether we still need mcrypt, or whether we can reasonably replace it with something else? I believe we used to use it for password hashing, but no longer do (using PHP's own salt/hash mechanism instead) and perhaps it's there for legacy only now?

@alexharrington alexharrington added the enhancement An improvement to an existing feature label Aug 21, 2018
@alexharrington alexharrington added this to the 1.8.12 milestone Aug 21, 2018
@dasgarner
Copy link
Member

The mcrypt extension is used by Slim 2, although is suggested rather than required.

Password checking (as you say) uses mcrypt only if the password has not yet been upgraded to the latest method. Removing it would mean that a user must go through the current release to get to the next.

@alexharrington
Copy link
Member Author

alexharrington commented Aug 22, 2018

So we could make it suggested but not required (with that caveat)? I believe there's a pure PHP polyfill for it too, which might be a sensible option?

@dasgarner dasgarner self-assigned this Sep 4, 2018
@dasgarner
Copy link
Member

The polyfill makes the most sense I think - we could include that and drop the requirement for the extension as a whole.

dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants