Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: system notifications should also go to assigned users #2973

Closed
dasgarner opened this issue Dec 23, 2022 · 0 comments
Closed
Assignees
Projects
Milestone

Comments

@dasgarner
Copy link
Member

In #2957 we fixed a problem whereby system notifications were not being sent to the mail_to if one had been specified. In fixing this problem the logic as it was stated now works, which is to say that when a notification is a system notification it does not send to the assigned users.

In hindsight this logic seems wrong - a notification should go to all assigned users, and additionally the mail_to user if it is a system notification.

@dasgarner dasgarner added this to the 3.3.2 milestone Dec 23, 2022
@dasgarner dasgarner added this to To do in Xibo CMS via automation Dec 23, 2022
@PeterMis PeterMis self-assigned this Jan 3, 2023
@PeterMis PeterMis moved this from To do to In progress in Xibo CMS Jan 4, 2023
@PeterMis PeterMis moved this from In progress to Review in progress in Xibo CMS Jan 4, 2023
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Jan 5, 2023
Xibo CMS automation moved this from Review in progress to Done Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Xibo CMS
  
Done
Development

No branches or pull requests

2 participants