Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget: Agenda with an invalid custom date interval causes the layout to fail to load #3060

Closed
dasgarner opened this issue Jun 5, 2023 · 0 comments · Fixed by xibosignage/xibo-cms#1845
Closed

Widget: Agenda with an invalid custom date interval causes the layout to fail to load #3060

dasgarner opened this issue Jun 5, 2023 · 0 comments · Fixed by xibosignage/xibo-cms#1845
Assignees
@dasgarner
Labels
bug
Milestone
3.3.6

Comments

@dasgarner
Copy link
Member

This is because we're passing false into add in Agenda isValid().

/vendor/nesbot/carbon/src/Carbon/Traits/Units.php(219): Carbon\Carbon->addUnit()

I think this may also effect v4.
@dasgarner dasgarner added the bug label Jun 5, 2023
@dasgarner dasgarner modified the milestones: 3.3.7, 3.3.6 Jun 5, 2023
@dasgarner dasgarner self-assigned this Jun 5, 2023
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Jun 5, 2023
@dasgarner
Widget: agenda/calendar validation of custom interval xibosignage/xib…
2b70ea0 
…o#3060
@dasgarner dasgarner mentioned this issue Jun 5, 2023
Merged
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Jun 5, 2023
@dasgarner
Widget: agenda/calendar validation of custom interval xibosignage/xib…
b1e2206 
…o#3060
@dasgarner dasgarner mentioned this issue Jun 5, 2023
Merged
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jun 6, 2023
@dasgarner
Misc fixes for 3.3.6 (#1845)
50360de 
* Widget: agenda/calendar validation of custom interval xibosignage/xibo#3060
* Layout: created/modified dt is incorrectly parsed as a Carbon date by the LayoutFactory xibosignage/xibo#3061
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jun 6, 2023
@dasgarner
Misc minor fixes (#1846)
4dfe224 
* Widget: agenda/calendar validation of custom interval xibosignage/xibo#3060
* Layout: created/modified dt is incorrectly parsed as a Carbon date by the LayoutFactory xibosignage/xibo#3061
* Connector: invalid stock symbol shouldn't break whole return xibosignageltd/xibo#290
* XMDS: fix non-http dependency downloads (check relative path)
* Layout: import not matching exiting datasets xibosignageltd/xibo#292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
bug
Projects
None yet
Milestone
3.3.6
Development

Successfully merging a pull request may close this issue.

Widget: agenda/calendar validation of custom interval dasgarner/xibo-cms
1 participant
@dasgarner