Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMDS: some URLs have spaces in them #3152

Closed
dasgarner opened this issue Sep 15, 2023 · 2 comments
Closed

XMDS: some URLs have spaces in them #3152

dasgarner opened this issue Sep 15, 2023 · 2 comments
Assignees
@PeterMis
Labels
bug
Milestone
4.0.4

Comments

@dasgarner
Copy link
Member

The easiest way to recreate is to upload a font which has spaces in the file name. This will appear in the required files XML as file=Open Sans Regular.ttf instead of ``file=Open+Sans+Regular.ttf`

Most of the players don't seem to care, and correctly encode the URL before sending it. However, then we serve files via the CDN, they are considered invalid.
@dasgarner dasgarner added the bug label Sep 15, 2023
@dasgarner dasgarner added this to the 4.0.3 milestone Sep 15, 2023
@dasgarner
Copy link
Member Author

After fixing this we will need to validate that files with +'s in them are downloaded by players (which is already working with spaces in the XML)

@dasgarner dasgarner modified the milestones: 4.0.3, 4.0.4 Sep 18, 2023
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Oct 2, 2023
@PeterMis
Fonts : use regex on fileName to avoid issues downloading on the Players
bc9449c 
xibosignage/xibo#3152
@PeterMis PeterMis mentioned this issue Oct 2, 2023
Merged
PeterMis added a commit to xibosignage/xibo-cms that referenced this issue Oct 2, 2023
@PeterMis
Bugfixes 4.0.4 issues (#2124)
6c8f0a0 
* Video Upload : Fix thumbnail capture without manual adjustments in the preview window. xibosignage/xibo#3153
* Schedule Calendar : Fix moment js issues with custom date formats. xibosignage/xibo#3149
* DataSets : Fix issues with replacements for displayId and displayGeoLocation xibosignage/xibo#3144
* Stocks : Fix AlphaVantage API endpoint for free and paid keys. xibosignage/xibo#3168
* Status Dashboard : Fix ordering by Faults column. xibosignage/xibo#3170
* Folders page : Fix Folder details xibosignage/xibo#3171
* Fonts : use regex on fileName to avoid issues downloading on the Players xibosignage/xibo#3152
* Schedule : Sync form layouts search should use url_for. xibosignage/xibo#3158
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Oct 9, 2023
@dasgarner @rubenpingol-xibo
@maurofmferrao @ifarzana @PeterMis
Merge pull request #2134 from xibosignage/develop
1c56b38 
* Missing API docs
* Missing API docs

* Missing API docs

* Select2: Fix search focus (#2111)

* Widget: text flickers after upgrade (rich text) (#2112)

relates to xibosignage/xibo#3157

* Swagger: build out for modules/module templates.

* Update readme with new branch versions.

* Swagger: Property default.

* Misc fixes for 4.0.4 (#2113)

* Bump version.
* Modules: BE mapping for the escapeHtml attribute on extends, needs FE completion. xibosignageltd/xibo-private#494
* Modules: Improve module not enabled message xibosignageltd/xibo-private#472
* Upgrade: handle duplicate modules on upgrade. xibosignage/xibo#3137
* RSS: date parsing broken in php 8.2 (in picofeed) xibosignage/xibo#3148
* Embedded: default should be off for transparency, scale content and pre navigate xibosignage/xibo#3146

* Cypress - saving artifacts and misc fixes (#2114)

* API: extend class missing escape attribute used for elements FE (#2115)

relates to xibosignageltd/xibo-private#494

* Show error message on Elements with bad configured widget (#2116)

relates to xibosignageltd/xibo-private#499

* v3 module import fixes (#2118)

relates to xibosignageltd/xibo-private#495

* Embedded: CSS with special chars
* Weather: name="text-color" field not being applied
* Weather: xibo-legacy-template-render match fix
* Weather: Background image being forced on override
* Module preview: wrong icon

* Player: use reportFault second param object for setting targetId (#2117)

* Player: use reportFault second param object for setting targetId
relates to xibosignageltd/xibo-private#264

* Player: call xiboIC.expireNow when data is not found after XHR request
relates to xibosignageltd/xibo-private#264

* Widget Elements: Fix date formatting with onTemplateRender (#2119)

relates to xibosignage/xibo#3138

* Editors: Review all messages, labels and help text content (#2121)

relates to xibosignageltd/xibo-private#504

* Editor automatic layers refactor (#2120)

relates to xibosignageltd/xibo-private#503

 - Added layer to element groups
 - Context menu controls for layers in element groups
 - Element groups added to layer manager
 - Refactor layer manager
 - Layer manager keep scroll position

* Bugfixes 4.0.4 issues (#2124)

* Video Upload : Fix thumbnail capture without manual adjustments in the preview window. xibosignage/xibo#3153
* Schedule Calendar : Fix moment js issues with custom date formats. xibosignage/xibo#3149
* DataSets : Fix issues with replacements for displayId and displayGeoLocation xibosignage/xibo#3144
* Stocks : Fix AlphaVantage API endpoint for free and paid keys. xibosignage/xibo#3168
* Status Dashboard : Fix ordering by Faults column. xibosignage/xibo#3170
* Folders page : Fix Folder details xibosignage/xibo#3171
* Fonts : use regex on fileName to avoid issues downloading on the Players xibosignage/xibo#3152
* Schedule : Sync form layouts search should use url_for. xibosignage/xibo#3158

* Add delete button to drawer widget select (#2126)

relates to xibosignageltd/xibo-private#483

 - Removed delete button from PPanel

* Widget fixes for Dashboard and DataSet (#2128)

* Dashboard: add a template so the widget can be added. fixes xibosignage/xibo#3176
* Widget: dataset no data message doesn't work fixes xibosignage/xibo#3177
* Widget: dataset include a string template on playlists (also image slideshow should be playlist only). 
 * Fix playlist only, fix template icon.

* Misc issues for 4.0.4 (#2125)

* Widget: embedded to have a head option xibosignage/xibo#3141
* Widget: embedded javascript should allow library references. xibosignage/xibo#3134
* Regular Maintenance: linked files shouldn't be removed. xibosignage/xibo#3143

* Elements: Final fix for scrollHorz effect (#2127)

* Bugifxes 4.0.4 issues part2 (#2129)

* Schedule : Throw specific error when not all Displays in Sync Group were given a Layout. xibosignage/xibo#3150
* Maintenance : Remove weather-humidity-percent asset, as it is no longer needed. xibosignage/xibo#3155
* Custom Install : Make sure we create fonts sub-folder under selected Library directory during install process. xibosignage/xibo#3156
* Layout : Make sure we only show enabled Resolutions in the dropdown in Layout Editor - while also always including currently selected resolution. xibosignage/xibo#3173
* Library Upload : Protect against empty default resize limit CMS setting. xibosignage/xibo#3159

* Bugfix/4.0.4 fixes (#2131)

* Show error message only on element group
relates to xibosignageltd/xibo-private#499

* Playlists: cannot scroll, the scroll bars are not displayed
relates to xibosignage/xibo#3161

* Layout Editor: Add upload card to playlist crashes
relates to xibosignageltd/xibo-private#498

* Layer manager fixes (#2130)

relates to xibosignageltd/xibo-private#503

 - Select item on layer manager to put on top fix
- Canvas layer is also calculated
 - Element group layer defaults to 0 for empty canvas
 - Prevent multi refreshes when deleting element group

* Widget: Weather background choose from library (#2132)

* Playlists scroll inline fix (#2133)

relates to xibosignage/xibo#3161

* Release 4.0.4 final prep (#2139)
* Status dashboard: Remove log
* Update translations, build swagger docs.

---------

Co-authored-by: Ruben Pingol <128448242+rubenpingol-xibo@users.noreply.github.com>
Co-authored-by: Mauro Ferrão <maurofmferrao@gmail.com>
Co-authored-by: Israt Jahan Farzana <m2farzana@gmail.com>
Co-authored-by: Peter <peter@xibosignage.com>
@dasgarner
Copy link
Member Author

✅ tested that fonts with reserved characters get uploaded correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug
Projects
None yet
Milestone
4.0.4
Development

No branches or pull requests
2 participants
@dasgarner @PeterMis