Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget: DataSet Image Slideshow doesn't show DataSet Field when the dataset has no image columns #3178

Closed
dasgarner opened this issue Oct 3, 2023 · 3 comments
Closed

Widget: DataSet Image Slideshow doesn't show DataSet Field when the dataset has no image columns #3178

dasgarner opened this issue Oct 3, 2023 · 3 comments
Assignees
@rubenpingol-xibo
Labels
bug
Milestone
4.0.5

Comments

@dasgarner
Copy link
Member

This is confusing as it isn't clear what the user needs to do. A message should be displayed asking them to select a dataset with an image field.
@dasgarner dasgarner added the bug label Oct 3, 2023
@dasgarner dasgarner added this to the 4.0.5 milestone Oct 3, 2023
@rubenpingol-xibo
Copy link

Tested by @maurofmferrao and this is already working.

@rubenpingol-xibo
Copy link

Apparently, it's working for elements but not for static widget.

rubenpingol-xibo added a commit to rubenpingol-xibo/xibo-cms that referenced this issue Oct 23, 2023
@rubenpingol-xibo
Widget: DataSet static image slideshow no image field message
3fb2a6f 
relates to xibosignage/xibo#3178
@rubenpingol-xibo rubenpingol-xibo mentioned this issue Oct 23, 2023
Merged
rubenpingol-xibo added a commit to xibosignage/xibo-cms that referenced this issue Oct 23, 2023
@rubenpingol-xibo
Widget: DataSet Image Slideshow doesn't show DataSet Field when the d…
111ae17 
…ataset has no image columns

relates to xibosignage/xibo#3178
@dasgarner
Copy link
Member Author

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenpingol-xibo rubenpingol-xibo

Labels
bug
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
2 participants
@dasgarner @rubenpingol-xibo