Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad Campaign : Potential of Division by zero error #3206

Closed
PeterMis opened this issue Oct 24, 2023 · 1 comment
Closed

Ad Campaign : Potential of Division by zero error #3206

PeterMis opened this issue Oct 24, 2023 · 1 comment
Assignees
@PeterMis
Labels
bug
Milestone
4.0.5

Comments

@PeterMis
Copy link
Member

If start and end date for ad campaign are set to the same date, then the difference in days between the two dates will be 0.

We use this difference to calculate target per day, which makes the CMS very unhappy if we try to divide by 0 there.

The validation of an ad Campaign should be improved to avoid such cases.
@PeterMis PeterMis added the bug label Oct 24, 2023
@PeterMis PeterMis added this to the 4.0.5 milestone Oct 24, 2023
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Nov 1, 2023
@PeterMis
Ad Campaign : Protect against division by 0 when start and end date a…
55bc731 
…re the same.

Fixes xibosignage/xibo#3206
@ifarzana
Copy link

ifarzana commented Nov 2, 2023

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
2 participants
@ifarzana @PeterMis