Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock Widget: Unable to upgrade digital clock from V3 to V4 #3275

Closed
ifarzana opened this issue Dec 14, 2023 · 3 comments · Fixed by xibosignage/xibo-cms#2335
Closed

Clock Widget: Unable to upgrade digital clock from V3 to V4 #3275

ifarzana opened this issue Dec 14, 2023 · 3 comments · Fixed by xibosignage/xibo-cms#2335
Assignees
@dasgarner
Labels
bug
Milestone
4.0.7

Comments

@ifarzana
Copy link

ifarzana commented Dec 14, 2023 •
edited

An issue arises during the upgrade process from V3 to V4, where a layout featuring a digital clock does not undergo the expected upgrade. Instead, the upgraded layout displays an analogue clock.

It looks like we return the first module which is clock -analogue rather than the clock-digital https://github.com/xibosignage/xibo-cms/blob/develop/lib/Factory/ModuleFactory.php#L358
@ifarzana ifarzana added the bug label Dec 14, 2023
@ifarzana ifarzana added this to the 4.0.7 milestone Dec 14, 2023
@dasgarner
Copy link
Member

Just a note that we fixed and tested this before, so there must be something more: #3109

@dasgarner
Copy link
Member

Related issue regarding the analogue clock: #3314

dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Jan 29, 2024
@dasgarner
Widget: clock widget upgrade issue (type changing back to analogue). x…
c314c73 
…ibosignage/xibo#3275
@dasgarner dasgarner mentioned this issue Jan 29, 2024
Merged
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jan 29, 2024
@dasgarner
Widget: clock widget upgrade issue (type changing back to analogue). (#…
e8f54f1 
…2335)

fixes xibosignage/xibo#3275
@ifarzana
Copy link
Author

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
bug
Projects
None yet
Milestone
4.0.7
Development

Successfully merging a pull request may close this issue.

Widget: clock widget upgrade issue (type changing back to analogue) dasgarner/xibo-cms
4 participants
@ifarzana @dasgarner @maurofmferrao @rubenpingol-xibo