Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Element outputs a broken thumbnail when not shared #3291

Closed
maurofmferrao opened this issue Jan 4, 2024 · 1 comment
Closed

Image Element outputs a broken thumbnail when not shared #3291

maurofmferrao opened this issue Jan 4, 2024 · 1 comment
Assignees
@dasgarner
Labels
bug
Milestone
4.0.7

Comments

@maurofmferrao
Copy link
Member

maurofmferrao commented Jan 4, 2024 •
edited by dasgarner

A user without permission for a certain image will still see it as a broken thumbnail in an element created by another user.

It would be better if we could show an error image, or a blurry image perhaps.
@maurofmferrao maurofmferrao added this to the 4.0.7 milestone Jan 4, 2024
@dasgarner dasgarner self-assigned this Jan 8, 2024
@dasgarner dasgarner changed the title Image Element media permission ignored Image Element outputs a broken thumbnail when not shared Jan 23, 2024
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Jan 23, 2024
@dasgarner
Image element should not output a broken thumbnail if not shared. fixes
f037240 
xibosignage/xibo#3291

Module images shouldn't be accessible to all (fixed a pending TODO).
@ifarzana
Copy link

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
bug
Projects
None yet
Milestone
4.0.7
Development

No branches or pull requests
3 participants
@ifarzana @dasgarner @maurofmferrao