Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget: DataSet widget in v4 has a freshness timeout option not right for elements #3358

Closed
dasgarner opened this issue Mar 4, 2024 · 0 comments
Closed

Widget: DataSet widget in v4 has a freshness timeout option not right for elements #3358

dasgarner opened this issue Mar 4, 2024 · 0 comments
Assignees
@dasgarner
Labels
bug
Milestone
4.0.10

Comments

@dasgarner
Copy link
Member

It relies on a no data template, which isn't available for elements. It might make more sense to clear the items array if the timeout has passed, allowing the template to decide what to do when it has no items.
@dasgarner dasgarner added the bug label Mar 4, 2024
@dasgarner dasgarner added this to the 4.0.9 milestone Mar 4, 2024
@dasgarner dasgarner modified the milestones: 4.0.9, 4.0.10 Mar 18, 2024
@dasgarner dasgarner self-assigned this Mar 18, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Mar 28, 2024
@dasgarner
Widget: dataset freshness timeout updated to work for elements.
0184b3c 
 fixes xibosignage/xibo#3358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
bug
Projects
None yet
Milestone
4.0.10
Development

No branches or pull requests
1 participant
@dasgarner