Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset tables always created with charset utf8 instead of utf8mb4 #3380

Closed
LiaraAlis opened this issue Mar 19, 2024 · 0 comments · Fixed by xibosignage/xibo-cms#2472
Closed
Assignees
Labels
Milestone

Comments

@LiaraAlis
Copy link

With #3044 collation was switched to utf8mb4 to support emojis.
Now I upgraded our xibo to v4 and have noticed that it still doesn't work to include emojis in data sets. So I was able to find the following line:

https://github.com/xibosignage/xibo-cms/blob/49f018fd9fe64fcd417d7c2ef96078bd7b2b88b7/lib/Entity/DataSet.php#L1101

Changing line from

          ) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=1

to

          ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 AUTO_INCREMENT=1

fixes the problem, I already tried it on our system.

@dasgarner dasgarner added this to the 4.0.10 milestone Mar 19, 2024
@dasgarner dasgarner added the bug label Mar 19, 2024
@dasgarner dasgarner self-assigned this Mar 28, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Apr 5, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants