Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetResource Images - back fill missing images #990

Closed
dasgarner opened this issue Dec 23, 2016 · 1 comment
Closed

GetResource Images - back fill missing images #990

dasgarner opened this issue Dec 23, 2016 · 1 comment
Assignees
Labels
enhancement An improvement to an existing feature
Milestone

Comments

@dasgarner
Copy link
Member

Any images that don't load should be replaced by a 1px transparent square, a background retry should be attempted to back fill these images if they become available.

@dasgarner dasgarner added the enhancement An improvement to an existing feature label Dec 23, 2016
@dasgarner dasgarner added this to the 1.8.0-rc3 milestone Dec 23, 2016
@dasgarner
Copy link
Member Author

There is already something at the end of xibo-text-render.js which attempts to replace any error'ed images with a transparent PNG.

Perhaps should could be separated into its own JS file (and included in each relevant module), but also enhanced to periodically re-request the file and insert it if present.

maurofmferrao added a commit to maurofmferrao/xibo-cms that referenced this issue Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants