Skip to content

Commit

Permalink
don't swallow error
Browse files Browse the repository at this point in the history
Signed-off-by: Won Jun Jang <wjang@uber.com>
  • Loading branch information
black-adder committed Jan 28, 2019
1 parent a5bce46 commit 00d8881
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions storage/namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,9 @@ func (n *dbNamespace) QueryRaw(
if res == nil {
res = shardRes
} else {
// TODO(wjang): We are swallowing this error.
res.MergeInPlace(shardRes)
if err := res.MergeInPlace(shardRes); err != nil {
return nil, err
}
}
if res.IsComplete() {
// We've got enough data, bail early.
Expand Down

0 comments on commit 00d8881

Please sign in to comment.