Address feedback

xichen2020 · Mar 2, 2019 · 98828e5 · 98828e5
1 parent 0bf3a89
commit 98828e5
Show file tree

Hide file tree

Showing 4 changed files with 824 additions and 823 deletions.
diff --git a/calculation/value.go b/calculation/value.go
@@ -59,8 +59,9 @@ func (u ValueUnion) ToProto() servicepb.CalculationValue {
 			Type:      servicepb.CalculationValue_STRING,
 			StringVal: u.StringVal,
 		}
+	default:
+		panic(fmt.Errorf("unexpected calculation value type %v", u.Type))
 	}
-	panic(fmt.Errorf("unexpected calculation value type %v", u.Type))
 }
 
 // NewNumberUnion creates a new number union.

diff --git a/generated/proto/servicepb/document.pb.go b/generated/proto/servicepb/document.pb.go