early exit

xichen2020 · Jan 31, 2019 · a2b703f · a2b703f
1 parent 4288499
commit a2b703f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/values/decoding/dictionary_based_int_iterator.go b/values/decoding/dictionary_based_int_iterator.go
@@ -36,7 +36,8 @@ func newDictionaryBasedIntIterator(
 
 // Next iteration.
 func (it *dictionaryBasedIntIterator) Next() bool {
-	if it.err != nil {
+	// Bail early if dictionary is empty, ie values is also empty.
+	if it.err != nil || len(it.extDict) == 0 {
 		return false
 	}
 

diff --git a/values/decoding/dictionary_based_string_iterator.go b/values/decoding/dictionary_based_string_iterator.go
@@ -32,7 +32,8 @@ func newDictionaryBasedStringIterator(
 
 // Next iteration.
 func (it *dictionaryBasedStringIterator) Next() bool {
-	if it.err != nil {
+	// Bail early if dictionary is empty, ie values is also empty.
+	if it.err != nil || len(it.extDict) == 0 {
 		return false
 	}