Implement MarshalJSON for query results #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbdu
approved these changes
Feb 8, 2019
| @@ -16,18 +18,40 @@ const ( | |||
| StringType | |||
| ) | |||
|
|
|||
| var ( | |||
| nullBytes = []byte("null") | |||
There was a problem hiding this comment.
Do we want to define this somewhere in a shared location?
There was a problem hiding this comment.
Hm a bit overkill given this is only used in two places in two separate packages.
black-adder
approved these changes
Feb 8, 2019
query/result_group.go
Outdated
| @@ -5,15 +5,28 @@ import ( | |||
| "github.com/xichen2020/eventdb/x/compare" | |||
| ) | |||
|
|
|||
| type nullResultGruop struct { | |||
query/result_group.go
Outdated
| Values calculation.ResultArray `json:"values"` | ||
| } | ||
|
|
||
| type nullResultGruopsJSON struct { |
| @@ -0,0 +1,114 @@ | |||
| package query | |||
query/time_bucket_result.go
Outdated
| } | ||
|
|
||
| type timeBucketJSON struct { | ||
| StartAt int64 `json:"startAt"` // In nanoseconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @notbdu @black-adder
This PR implements
MarshalJSONfor the various types of query results.Fixes #112