oci_discovery/ref_engine_discovery/__main__.py: Add --protocol and --port #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of --https-only. This allows us to specify HTTP-only when we want to, e.g. testing against a server that does not support TLS.
To allow users to easily test against ref-engine discovery services running on non-standard ports. For example: $ python3 -m oci_discovery.ref_engine_discovery --protocol http --port 8080 '[::1]/app#1.0'
|
LGTM It works correctly. Later we may support resolution like: Because consumers want this do be resolved automatically IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
--protocolreplacing the old--https-only. With these changes, you can do things like:when testing locally.
Fixes #9 (although there are probably other ways we could address that too).