Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New input to control activation/deactivation of chart auto-resize feature #73

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

arethore-actility
Copy link
Contributor

I'm working on an app where the chart auto-resize feature is conflicting with the rendering of other components when toggling from/to fullscreen view.
I'd like to be able to control whether or not this auto-resize feature is activated.

I propose to add an 'autoResize' input in NgxEchartsDirective, controlling the activation of the auto-resize feature triggered by a window resize event.
Of course, by default, the automatic resize feature is activated (autoResize = true).

…auto resize feature upon window resize event
@xieziyu
Copy link
Owner

xieziyu commented Feb 7, 2018

Thanks. It's useful.

@xieziyu xieziyu merged commit 14d4227 into xieziyu:master Feb 7, 2018
@covera
Copy link

covera commented Mar 29, 2018

這個 autoResize 只有在視窗改變大小的時候會觸發,但是 div container 改變大小時不會觸發,例如在使用側邊欄(sidenav)的情況下,圖表不會隨 sidenav 的開闔自動 resize

@xieziyu
Copy link
Owner

xieziyu commented Mar 29, 2018

@covera Yes, you should handle the case manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants