Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting descending is broken since last update | inverting of strcmp #34

Closed
susnux opened this issue Sep 12, 2019 · 2 comments
Closed

Sorting descending is broken since last update | inverting of strcmp #34

susnux opened this issue Sep 12, 2019 · 2 comments

Comments

@susnux
Copy link

susnux commented Sep 12, 2019

Since last update the descending sort is broken.

Your code $b = !$b does not what you might think it does.

strcmp return <0 =0 or >0, so the correct code would be $b *= -1.
@xif-fr
Copy link
Owner

xif-fr commented Sep 13, 2019

Oh right, this is embarrassing... I'll fix it tomorrow.

@xif-fr
Copy link
Owner

xif-fr commented Sep 13, 2019

Fixed. Thanks again.

@xif-fr xif-fr closed this as completed Sep 13, 2019
@susnux susnux mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@susnux @xif-fr