manubot#337 Allow setting timeout on ISBN search.

manubot/cite/isbn.py

@@ -4,6 +4,8 @@
 
 from .handlers import Handler
 
+timeout_seconds = 3
+
 
 class Handler_ISBN(Handler):
 
@@ -13,9 +15,12 @@ class Handler_ISBN(Handler):
         "isbn",
     ]
 
-    def inspect(self, citekey):
+    def inspect(self, citekey, timeout: int = timeout_seconds):
         import isbnlib
 
+        isbnlib.config.setthreadstimeout(seconds=timeout)
+        isbnlib.config.seturlopentimeout(seconds=timeout)
+
         fail = isbnlib.notisbn(citekey.accession, level="strict")
         if fail:
             return f"identifier violates the ISBN syntax according to isbnlib v{isbnlib.__version__}"
@@ -26,11 +31,11 @@ def standardize_prefix_accession(self, accession):
         accession = to_isbn13(accession)
         return self.standard_prefix, accession
 
-    def get_csl_item(self, citekey):
-        return get_isbn_csl_item(citekey.standard_accession)
+    def get_csl_item(self, citekey, timeout: int = timeout_seconds):
+        return get_isbn_csl_item(citekey.standard_accession, timeout=timeout)
 
 
-def get_isbn_csl_item(isbn: str):
+def get_isbn_csl_item(isbn: str, timeout: int = timeout_seconds):
     """
     Generate CSL JSON Data for an ISBN. Converts all ISBNs to 13-digit format.
 
@@ -41,6 +46,9 @@ def get_isbn_csl_item(isbn: str):
     """
     import isbnlib
 
+    isbnlib.config.setthreadstimeout(seconds=timeout)
+    isbnlib.config.seturlopentimeout(seconds=timeout)
+
     isbn = isbnlib.to_isbn13(isbn)
     for retriever in isbn_retrievers:
         try:
@@ -54,16 +62,16 @@ def get_isbn_csl_item(isbn: str):
     raise Exception(f"all get_isbn_csl_item methods failed for {isbn}")
 
 
-def get_isbn_csl_item_zotero(isbn: str):
+def get_isbn_csl_item_zotero(isbn: str, timeout: int = timeout_seconds):
     """
     Generate CSL JSON Data for an ISBN using Zotero's translation-server.
     """
     from manubot.cite.zotero import get_csl_item
 
-    return get_csl_item(f"isbn:{isbn}")
+    return get_csl_item(f"isbn:{isbn}", timeout=timeout)
 
 
-def get_isbn_csl_item_citoid(isbn: str):
+def get_isbn_csl_item_citoid(isbn: str, timeout: int = timeout_seconds):
     """
     Return CSL JSON Data for an ISBN using the Wikipedia Citoid API.
     https://en.wikipedia.org/api/rest_v1/#!/Citation/getCitation
@@ -74,7 +82,7 @@ def get_isbn_csl_item_citoid(isbn: str):
 
     headers = {"User-Agent": get_manubot_user_agent()}
     url = f"https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/{isbn}"
-    response = requests.get(url, headers=headers)
+    response = requests.get(url, headers=headers, timeout=timeout)
     result = response.json()
     if isinstance(result, dict):
         if result["title"] == "Not found.":
@@ -125,12 +133,15 @@ def get_isbn_csl_item_citoid(isbn: str):
     return csl_item
 
 
-def get_isbn_csl_item_isbnlib(isbn: str):
+def get_isbn_csl_item_isbnlib(isbn: str, timeout: int = timeout_seconds):
     """
     Generate CSL JSON Data for an ISBN using isbnlib.
     """
     import isbnlib
 
+    isbnlib.config.setthreadstimeout(seconds=timeout)
+    isbnlib.config.seturlopentimeout(seconds=timeout)
+
     metadata = isbnlib.meta(isbn)
     csl_json = isbnlib.registry.bibformatters["csl"](metadata)
     csl_data = json.loads(csl_json)