Links to ids don't produce Markdown links

[movermeyer]

When thehref is to an HTML id, no link is generated

link_to_external_site = '<a href="https://example.com#hallo">Hallo!</a>'
link_to_id = '<a href="#hallo">Hallo!</a>'

ReverseMarkdown.convert(link_to_external_site, github_flavored: true, tag_border: '')
=> "[Hallo!](https://example.com#hallo)"

ReverseMarkdown.convert(link_to_id, github_flavored: true, tag_border: '')
=> "Hallo!"

In the second case, I expected [Hallo!](#hallo), not Hallo!.

[movermeyer]

Looking into this further, it seems that this was intended behaviour at one point:

• reverse_markdown/spec/assets/anchors.html

  Line 9 in cd24cc3

  pass through the text of <a href="#content">internal jumplinks</a> without treating them as links

• reverse_markdown/spec/components/anchors_spec.rb

  Line 23 in 966e3d7

  it { is_expected.to include ' pass through the text of internal jumplinks without treating them as links ' }

I'd like to argue that this is the wrong behaviour. Markdown/CommonMark supports jump links (see this file's table of contents for example) and the CommonMark spec allows for any characters in the link destination, including fragments

[xijo]

Hi,

Thanks for reporting. Sounds right: jump marks should work as you'd expect them to. I'll have a look and get back to you alright?

Cheers,
Jo

[xijo]

Released as 1.4.0. Thanks again!