feat: add modal footer buttons for new tab and close #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is opening the manual in a new tab really the primary action? Currently the backend preview URL is used, so that the TYPO3 backend is opened again. Should we maybe use the frontend url? |
|
For some editors, the manual may simply be displayed too small in the iFrame. That's why the simple idea of opening it in a new tab, whether this happens in the backend or frontend, is less relevant in my opinion. But yes, you can mentioned this button as secondary or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usability feature to add footer buttons for modal manual view.