Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysinfo: Swap arguments of g_pattern_match_simple #592

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

livingsilver94
Copy link
Contributor

According to the GLib doc the globbed pattern is the first argument, while the string to test comes after.

This fixes the fact that as_system_info_has_device_matching_modalias could return TRUE for a 1:1 equality with the pattern, but always returned FALSE when using wildcards.

@ximion
Copy link
Owner

ximion commented Feb 14, 2024

That mistake from the Windows port truly is a gift that keeps on giving...
Apparently I didn't find all cases when looking through it. This for sure needs a testcase, but in the meanwhile I see no reason not to merge this.

Thank you for finding this and for fixing it! :-)

@ximion ximion merged commit 07fe3c1 into ximion:main Feb 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants