Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade Jest to version 26 (v14.x) #1857

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

hops-release-bot[bot]
Copy link

⚠️ This PR is the successor of #1856 and has been created automatically because the previous PR's commits could not be cherry-picked. ⚠️

Please resolve the conflicts and merge this PR afterwards by running the following command:

git fetch origin && \
git fetch origin pull/1856/head && \
git checkout downgrade-jest-v14.x && \
git reset --hard HEAD^ && \
git cherry-pick 63c8ce718d5155d1612a0f66bb621eb80650d175

After successfully resolving all conflicts, you need to force-push your changes.

git push --force origin downgrade-jest-v14.x

...in order to get rid of the error...

Error: [BABEL]: Reentrant plugin detected trying to load "fea/hops/node_modules/jest-preset-hops/helpers/babel-plugin-rename-corejs.js". This module is not ignored and is trying to load itself while compiling itself, leading to a dependency cycle. We recommend adding it to your "ignore" list in your babelrc, or to a .babelignore. (While processing: fea/hops/node_modules/jest-preset-hops/helpers/babel-plugin-rename-corejs.js)

...when the Jest cache is warmed

Bors merge bot cheat sheet

We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax Description
bors merge Run the test suite and push to master if it passes. Short for "reviewed: looks good."
bors merge- Cancel an r+, r=, merge, or merge=
bors try Run the test suite without pushing to master.
bors try- Cancel a try
bors delegate+ Allow the pull request author to merge their changes.
bors delegate=[list] Allow the listed users to r+ this pull request's changes.
bors retry Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

@hops-release-bot hops-release-bot bot added the 📦 v14 Apply this label to a pull request, if it has to be cherry-picked to the v14.x-branch after merging. label Jun 10, 2021
...in order to get rid of the error...

```
Error: [BABEL]: Reentrant plugin detected trying to load
"fea/hops/node_modules/jest-preset-hops/helpers/babel-plugin-rename-corejs.js".
This module is not ignored and is trying to load itself while compiling itself,
leading to a dependency cycle. We recommend adding it to your "ignore" list in
your babelrc, or to a .babelignore. (While processing:
fea/hops/node_modules/jest-preset-hops/helpers/babel-plugin-rename-corejs.js)
```

...when the Jest cache is warmed
@herschel666 herschel666 marked this pull request as ready for review June 14, 2021 07:45
Copy link
Contributor

@herschel666 herschel666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 14, 2021

Build succeeded:

@bors bors bot merged commit a8d3a86 into release-bot/next-v14.x Jun 14, 2021
@bors bors bot deleted the downgrade-jest-v14.x branch June 14, 2021 08:07
@hops-release-bot hops-release-bot bot mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 v14 Apply this label to a pull request, if it has to be cherry-picked to the v14.x-branch after merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant