Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create same hashes on server and client #1976

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Commits on Sep 29, 2021

  1. fix: create same hashes on server and client

    we saw a behaviour with dynamic imports for SSR, when the import
    was directly referenced, e.g. with `import(./foo')` instead of
    `import('./')` webpack would with create different filehashes in
    the moduleMap when the option `usedExports` is enabled.
    
    filenames before hashing in webpack with `usedExports` followed the
    pattern: `filename.js|abc`
    
    filenames without `usedExports` are simply the filename: `filename.js`
    
    they are then hashed in webpacks `HashedModuleIdsPlugin.js` with
    different results, leading to an incomplete modulesMap
    
    Co-authored-by: Jonas Holland <jonas.holland@new-work.se>
    robertkowalski and jhiode committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    167fc39 View commit details
    Browse the repository at this point in the history