Set correct mime type for cover #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opsidao
force-pushed
the
set-correct-mime-type-for-cover
branch
from
2bee9c1
to
158bebd
Compare
bacchir
approved these changes
Nov 26, 2019
| @@ -4,6 +4,26 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [0.3.1] - 2019-11-26 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the cover in the supported version of carrierwave, the content type is set to the one from the original file (PDF), not from the transformed one.
This generates CORB issues when serving the images inside iframes, so here I enforce the content type of the generated file manually.
I also add the missing entries to the changelog and do some minimal adaptation to the current versions of some dependencies.