Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle quote on windows #9

Merged
merged 1 commit into from Oct 18, 2017
Merged

handle quote on windows #9

merged 1 commit into from Oct 18, 2017

Conversation

metalkoholic
Copy link
Contributor

hi guys I found different behavior on windows, when use single quote it will raise error and should be use double quotes for parameters

gs -dNOPAUSE -sDEVICE='jpeg' -dJPEGQ=85 -sOutputFile=test.jpg -dGraphicsAlphaBits=4 -r300 -q pdf.pdf -c quit
Unknown device: 'jpeg'

gs -dNOPAUSE -sDEVICE="jpeg" -dJPEGQ=85 -sOutputFile=test.jpg -dGraphicsAlphaBits=4 -r300 -q pdf.pdf -c quit
worked well

@coveralls
Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 67fcb9a on metalkoholic:windows-fix into aa19854 on xing:master.

@opsidao
Copy link
Contributor

opsidao commented Oct 18, 2017

Hey @metalkoholic, thanks for the contribution!

I will merge and release a new patch version on rubygems, just give me a couple minutes ;)

@opsidao opsidao merged commit 203573f into xing:master Oct 18, 2017
@opsidao
Copy link
Contributor

opsidao commented Oct 18, 2017

You can find version 0.2.4 which incorporates your change on rubygems already.

@metalkoholic
Copy link
Contributor Author

hi @opsidao thank you for merge :)

@metalkoholic metalkoholic deleted the windows-fix branch October 18, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants