This repository has been archived by the owner on Mar 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
"alt-z" should not be undo with Windows+Polish keyboard #16
Comments
Expect that to be fixed tonight! :) |
Hey jamis, please check my changes (you have to locally execute "make" first to compile a new wysihtml5.js). Thanks! Ping me if this is still not fixed. |
Fantastic! I'm drowning in deadlines today and tomorrow, but I'll try and give this a test by Friday. Thanks for your quick response on this! |
Hey @tiff, not seeing this fixed and I just deployed the latest rev here. Maybe we need to check for https://github.com/xing/wysihtml5/blob/master/src/undo_manager.js#L48 |
tiff
pushed a commit
that referenced
this issue
Mar 15, 2012
Awesome, I'll give it another shot on our end. Thanks immensely for your awesome work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If you have Windows set to use the "Polish (programmer)" keyboard layout, you expect "alt+z" to insert "ż" (z with a dot over it). But wysihtml5 always maps alt+z to "undo", regardless of the default behavior.
This is happening in undo_manager.js in the "keydown" event handler, here: https://github.com/xing/wysihtml5/blob/master/src/undo_manager.js#L42-58
I'm not confident enough about the side-effects to say what the correct fix here is; maybe avoid mapping meta+z to "undo" when the platform is Windows?
The text was updated successfully, but these errors were encountered: