Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

Hide all parsing logic behind a Converter. #186

Merged
merged 5 commits into from
Sep 29, 2016
Merged

Conversation

serj-lotutovici
Copy link
Contributor

  • Created XingApi.moshi() that replaces XingApi.converter()
  • Created a Converter that is tied to the XingApi instance ( XingApi.converter() was made package private and returns the tied instance of Converter)
  • Converter hides all classes previously exposed by CompositeType.
  • JsonAdapter logic was re-arranged:
    • unwrapping/composite is maintained in Converter.CompositeJsonAdapter
    • list/fist(in list) logic was moved to Converter.ListTypeImplJsonAdapter

cc @dhartwich1991

Copy link
Contributor

@dhartwich1991 dhartwich1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool 😎 LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants