Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orientation correction technique #9

Closed
zouxy09 opened this issue Aug 7, 2019 · 2 comments
Closed

orientation correction technique #9

zouxy09 opened this issue Aug 7, 2019 · 2 comments

Comments

@zouxy09
Copy link

zouxy09 commented Aug 7, 2019

@xinshuoweng Hi, thanks for your sharing. I have a question about the orientation correction technique which add a π to the orientation that mentioned in your paper, but your code is self.kf.x[3] = -1 * self.kf.x[3] instead of self.kf.x[3] += np.pi, could you please explain why?

@zouxy09
Copy link
Author

zouxy09 commented Aug 7, 2019

I think you miss some considerations in the orientation correction technique, and I improve it and get the following result:
=================evaluation with confidence threshold 3.398000==================
MOTA MOTP MODA MODP MT ML IDS FRAG F1 Prec Recall FAR TP FP FN
0.7657 0.7916 0.7657 0.8375 0.7004 0.0727 0 50 0.8979 0.9327 0.8656 0.2229 24793 1790 3850
=====================evaluation: average at all thresholds======================
AMOTA AMOTP APrec
0.3948 0.7467 0.8444
All the items are little better than the results in your paper. I argue that your orientation correction technique is not suitable to all scenes, and the limit of kitti dataset cover up the mistakes.

@xinshuoweng
Copy link
Owner

xinshuoweng commented Aug 13, 2019

Thanks for pointing out! I believe you are right. This is a bug I have missed.

I have pushed a commit to fix this bug and got exact same results as yours.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants