-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the shortcut "Toggle editor" to the plugin #38
Comments
Is this to hide the editor and show only the sidebar? Don't you already have this feature with a lua script? |
No, it is to show only the editor, so to hide the sidebar.
The lua-script is the alternative to #37. |
So a similar lua script could resolve this too? |
No, this is not necessary because in Geany there is already the shortcut "Toggle Sidebar". When I press that shortcut, then I can see only the editor. But the two disadvantages are: |
If both disadvantages from my last comment could be solved, then why not. |
Trying to get focus to work has been frustrating. I'd rather not mess with it. Does "crisscross feature" mean that the different toggles are aware of each other? I think that can be managed in the scripts. It makes them a bit more complicated, but still easier to write lua script than to change C code. |
focus-feature
|
Today I have a better shortcut name than |
When the shortcut is active: |
Today I think it is better not to offer the crisscross-feature to the shortcut, because the shortcut So, if the shortcut is active (only editor is visible) and if the shortcut #37 is pressed, then nothing should happen. |
Just for information: |
It was good that this issue was not fixed, because I just recognized that the Lua Script (https://github.com/xiota/geanylua-scripts/tree/main/toggle-editor) works perfect for me, because I changed the last days the way to code. The focus stays always in the editor while toggling, and that's good. Two things that can be taken from this issue: |
condition
before to start to solve this issue, the shortcut name "Toggle between the editor and preview" should be changed to "Toggle between editor and preview" #34 (comment)
behavior
when pressing 1x the shortcut "Toggle editor", only the editor should appear; the highlighted line should be there
when pressing it again, the only-editor-view should not be there any more; the highlighted line should be there
reasons for adding the shortcut to the plugin
because the shortcut "Toggle Sidebar" of Geany does not have a state file, it is necessary to add the shortcut "Toggle editor" to the plugin (the shortcut "Toggle Sidebar" would correspond from the handling to the shortcut "Toggle editor" of Geany Preview), in order to add a state file, so that xiota/geanylua-scripts#3 and the crisscross feature down below can be solved
focus feature
always after pressing the shortcut: the content of the editor should be in focus, so the highlighted line should be there;
this feature is not necessary to program, because it works perfect at the moment with the shortcut "Toggle Sidebar", that would correspond to the shortcut "Toggle editor" in Geany Preview
crisscross feature
when pressing "Toggle sidebar", first the state file of the "Toggle sidebar" need to be checked;
so, if only-sidebar-view is active, then first de-activate only-sidebar-view
name of the shortcut
see explication in "name of the shortcut" in #37 (comment)
autoside-bar
this issue should also keep an eye on this issue xiota/geanylua-scripts#3;
when closing Geany
if only-editor-view is active:
The text was updated successfully, but these errors were encountered: